Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop attaching disk when get disk lun failed #2260

Merged

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: stop attaching disk when get disk lun failed
the driver should only attach disk when disk lun is not found on that VM

  • current error messages
E0326 01:48:28.227240 1 azure_controller_common.go:547] error of getting data disks for node aks-xxx-vmss000002: Retriable: true, RetryAfter: 0s, HTTPStatusCode: 500, RawError: {"error":{"code":"InternalServerError","message":"Encountered internal server error. Diagnostic information: timestamp '20240326T014828Z', subscription id 'xxx', tracking id 'c336091e-8e0e-4f9f-a21e-27faeed73a94', request correlation id 'c336091e-8e0e-4f9f-a21e-27faeed73a94'."}}
2024-03-26 01:48:28.0000000	csi-azuredisk-controller			I0326 01:48:28.227258 1 controllerserver.go:411] GetDiskLun returned: Retriable: true, RetryAfter: 0s, HTTPStatusCode: 500, RawError: {"error":{"code":"InternalServerError","message":"Encountered internal server error. Diagnostic information: timestamp '20240326T014828Z', subscription id 'xxx', tracking id 'c336091e-8e0e-4f9f-a21e-27faeed73a94', request correlation id 'c336091e-8e0e-4f9f-a21e-27faeed73a94'."}}. Initiating attaching volume /subscriptions/xxx/resourceGroups/sirius-aks-prod-cluster/providers/Microsoft.Compute/disks/xxx to node aks-xxx-vmss000002 (vmState <nil>).
2024-03-26 01:48:28.0000000	csi-azuredisk-controller			I0326 01:48:28.227285 1 controllerserver.go:438] Trying to attach volume /subscriptions/xxx/resourceGroups/sirius-aks-prod-cluster/providers/Microsoft.Compute/disks/xxx to node aks-xxx-vmss000002
2024-03-26 01:48:28.0000000	csi-azuredisk-controller			I0326 01:48:28.227388 1 azure_controller_common.go:203] found dangling volume /subscriptions/xxx/resourceGroups/sirius-aks-prod-cluster/providers/Microsoft.Compute/disks/xxx attached to node aks-static100822-61594791-vmss00003c, could not be attached to node(aks-xxx-vmss000002)

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: stop attaching disk when get disk lun failed

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from edreed and ZeroMagic April 7, 2024 02:06
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 7, 2024
@andyzhangx andyzhangx removed the request for review from edreed April 7, 2024 02:07
@andyzhangx
Copy link
Member Author

/retest

4 similar comments
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx merged commit c103313 into kubernetes-sigs:master Apr 7, 2024
24 of 25 checks passed
@andyzhangx
Copy link
Member Author

/cherrypick release-1.30

@andyzhangx
Copy link
Member Author

/cherrypick release-1.29

@andyzhangx
Copy link
Member Author

/cherrypick release-1.28

@k8s-infra-cherrypick-robot

@andyzhangx: new pull request created: #2262

In response to this:

/cherrypick release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@andyzhangx: #2260 failed to apply on top of branch "release-1.29":

Applying: fix: stop attaching disk when get disk lun failed
Using index info to reconstruct a base tree...
M	pkg/azuredisk/controllerserver.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/azuredisk/controllerserver.go
CONFLICT (content): Merge conflict in pkg/azuredisk/controllerserver.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: stop attaching disk when get disk lun failed
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@andyzhangx: #2260 failed to apply on top of branch "release-1.28":

Applying: fix: stop attaching disk when get disk lun failed
Using index info to reconstruct a base tree...
M	pkg/azuredisk/controllerserver.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/azuredisk/controllerserver.go
CONFLICT (content): Merge conflict in pkg/azuredisk/controllerserver.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: stop attaching disk when get disk lun failed
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants