Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add otel trace instrumentation on gRPC calls in helm chart #1912

Conversation

Fricounet
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Add cli flag to enable opentelemetry tracing
  • Add otel auto-intsrumentation on gRPC calls
  • Update helm chart to allow otel tracing configuration

Which issue(s) this PR fixes:
Fixes #1910

Requirements:

Special notes for your reviewer:
This code is used in our staging clusters and is working as expected.

Release note:

Added enable-otel-tracing flag to enable opentelemetry tracing. The flag is disabled by default. Only gRPC calls are currently instrumented

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 20, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @Fricounet!

It looks like this is your first PR to kubernetes-sigs/azuredisk-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/azuredisk-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @Fricounet. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 20, 2023
@Fricounet Fricounet changed the title Fricounet/upstream/otel tracing grpc Add otel trace instrumentation on gRPC calls Jul 20, 2023
@andyzhangx
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 20, 2023
@Fricounet
Copy link
Contributor Author

/retest

@Fricounet
Copy link
Contributor Author

not sure I understand why those 3 tests failed, gonna retry one and see if it is some kind of flakiness

/test pull-azuredisk-csi-driver-e2e-capz-windows-2022

@Fricounet
Copy link
Contributor Author

/retest

@andyzhangx andyzhangx removed the request for review from edreed July 21, 2023 02:31
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, Fricounet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2023
@andyzhangx andyzhangx changed the title Add otel trace instrumentation on gRPC calls feat: add otel trace instrumentation on gRPC calls in helm chart Jul 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1047c08 into kubernetes-sigs:master Jul 21, 2023
@andyzhangx
Copy link
Member

/cherrypick release-1.28

@k8s-infra-cherrypick-robot

@andyzhangx: #1912 failed to apply on top of branch "release-1.28":

Applying: feat: add otel gRPC tracing
Applying: feat(charts): add otel tracing configuration
Using index info to reconstruct a base tree...
M	charts/README.md
A	charts/latest/azuredisk-csi-driver-v0.0.0.tgz
M	charts/latest/azuredisk-csi-driver/values.yaml
Falling back to patching base and 3-way merge...
Auto-merging charts/latest/azuredisk-csi-driver/values.yaml
CONFLICT (modify/delete): charts/latest/azuredisk-csi-driver-v0.0.0.tgz deleted in HEAD and modified in feat(charts): add otel tracing configuration. Version feat(charts): add otel tracing configuration of charts/latest/azuredisk-csi-driver-v0.0.0.tgz left in tree.
Auto-merging charts/README.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 feat(charts): add otel tracing configuration
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fricounet
Copy link
Contributor Author

@andyzhangx seems like the cherry-pick command failed, should it be done manually?

@andyzhangx
Copy link
Member

@andyzhangx seems like the cherry-pick command failed, should it be done manually?

@Fricounet that's not necessary, let me cut a new v1.29.0 release later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add otel trace instrumentation on gRPC calls
4 participants