Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2]chore: adjust rate limiter to drive to target CRP limits #1529

Merged
merged 1 commit into from
Sep 26, 2022
Merged

[v2]chore: adjust rate limiter to drive to target CRP limits #1529

merged 1 commit into from
Sep 26, 2022

Conversation

edreed
Copy link
Collaborator

@edreed edreed commented Sep 26, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Adjust the Kubeclient and CRP attach/detach rate limiter configuration to enable the V2 driver to saturate the CRP limits of 240 queries per 3-minute period during scale tests.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 26, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2022
sunpa93
sunpa93 approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@sunpa93 sunpa93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edreed, sunpa93

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 127b154 into kubernetes-sigs:main_v2 Sep 26, 2022
@andyzhangx andyzhangx changed the title chore: adjust rate limiter to drive to target CRP limits [v2]chore: adjust rate limiter to drive to target CRP limits Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunpa93 sunpa93 sunpa93 approved these changes

@landreasyan landreasyan Awaiting requested review from landreasyan

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@sunpa93 sunpa93

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edreed @k8s-ci-robot @sunpa93