[V2] feat: make initial attach/detach disk batch delay configurable #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/L
k8s-ci-robot
added
the
approved
sunpa93
reviewed
Sep 19, 2022
edreed
force-pushed
the
edreed-configure-batch-delay
branch
from
3d106c0 to
b4c9b9a
Compare
edreed
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edreed, landreasyan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Allows the initial batch delay for attach and detach disk operations to be configured on the CSI controller.
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
This PR adds a new field,
azureClientAttachDetachBatchInitialDelayInMillis, to theCloudConfigurationstructure. The field can either be set as part of theAzDriverConfigurationpassed to the--configparameter, or theattach-detach-batch-initial-delaycommand-line parameter.The setting can be overridden when installing via Helm through the
controller.azureClientAttachDetachBatchInitialDelayInMillisvalue.Release note: