Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding optional workload value to pod-failover #1504

Merged
merged 1 commit into from
Sep 10, 2022
Merged

fix: adding optional workload value to pod-failover #1504

merged 1 commit into from
Sep 10, 2022

Conversation

connorbradshaw10
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
adding ability to specify workload type to pod failover tests

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 8, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @connorbradshaw10. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 8, 2022
@abhisheksinghbaghel
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2022
@connorbradshaw10
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@connorbradshaw10: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhisheksinghbaghel
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 9, 2022
@connorbradshaw10
Copy link
Contributor Author

/retest

1 similar comment
@connorbradshaw10
Copy link
Contributor Author

/retest

@connorbradshaw10
Copy link
Contributor Author

/approve

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2022
@mukhoakash
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2022
@connorbradshaw10
fix: adding optional workload value to pod-failover
9651f76 
- adding ability to specify workload type to pod failover tests
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2022
@landreasyan
Copy link
Contributor

/lgtm /approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhisheksinghbaghel, connorbradshaw10, landreasyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2022
@landreasyan
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit a1c650a into kubernetes-sigs:main_v2 Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukhoakash mukhoakash mukhoakash left review comments

@landreasyan landreasyan landreasyan approved these changes

@abhisheksinghbaghel abhisheksinghbaghel abhisheksinghbaghel approved these changes

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@abhisheksinghbaghel abhisheksinghbaghel

@landreasyan landreasyan

@mukhoakash mukhoakash

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@connorbradshaw10 @k8s-ci-robot @abhisheksinghbaghel @mukhoakash @landreasyan