-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V2] chore: Add ability to point at different image for servercore 🔧 #1459
Conversation
Hi @jmclong. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edreed, jmclong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
First test failure is related to hiccup installing "kind:"
I tried it on my machine and it was successful. I think mitigation would be to retry installing. Second failure in
|
/retest |
pull-azuredisk-csi-driver-e2e-capz-mainv2: Timed out on make |
/retest |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Currently, we depend on "cached" version servercore from the GCR to build the driver image for Windows. Most Go programs require only the binaries from nanoserver, but also one binary (NetApi32) from servercore. "servercore" is very large, so we pull from the "cached" version to speed up builds. This cached version is built by the kubernetes repo for the linux/amd64 and linux/arm64 platforms.
However, in ADO, we are only able to pull from MCR images. In order to provide this functionality while preserving the speedup from using the servercore-cache outside of ADO, I added the
SERVERCORE_IMAGE
andSERVERCORE_PLATFORM
build-args to let me setSERVERCORE_PLATFORM=windows/amd64
andSERVERCORE_IMAGE=mcr.microsoft.com/windows/servercore
.Requirements:
Special notes for your reviewer:
Release note: