Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] chore: Add ability to point at different image for servercore 🔧 #1459

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

jmclong
Copy link

@jmclong jmclong commented Aug 10, 2022

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Currently, we depend on "cached" version servercore from the GCR to build the driver image for Windows. Most Go programs require only the binaries from nanoserver, but also one binary (NetApi32) from servercore. "servercore" is very large, so we pull from the "cached" version to speed up builds. This cached version is built by the kubernetes repo for the linux/amd64 and linux/arm64 platforms.

However, in ADO, we are only able to pull from MCR images. In order to provide this functionality while preserving the speedup from using the servercore-cache outside of ADO, I added the SERVERCORE_IMAGE and SERVERCORE_PLATFORM build-args to let me set SERVERCORE_PLATFORM=windows/amd64 and SERVERCORE_IMAGE=mcr.microsoft.com/windows/servercore.

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 10, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @jmclong. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 10, 2022
@jmclong jmclong marked this pull request as ready for review August 10, 2022 14:17
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2022
@edreed edreed removed the request for review from ZeroMagic August 10, 2022 16:21
@edreed
Copy link
Collaborator

edreed commented Aug 10, 2022

/ok-to-test
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edreed, jmclong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 10, 2022
@jmclong
Copy link
Author

jmclong commented Aug 10, 2022

First test failure is related to hiccup installing "kind:"

curl -Lo ./bin/kind https://kind.sigs.k8s.io/dl/v0.11.1/kind-linux-amd64

I tried it on my machine and it was successful. I think mitigation would be to retry installing.

Second failure in pull-azuredisk-csi-driver-external-e2e-single-az-mainv2:

aks-engine indicates that ARM deployment failed. I think this would also be a sporadic issue.

@jmclong
Copy link
Author

jmclong commented Aug 10, 2022

/retest

@jmclong
Copy link
Author

jmclong commented Aug 10, 2022

pull-azuredisk-csi-driver-e2e-capz-mainv2:

Timed out on make e2e-teardown, seems like unrelated to this change.

@jmclong
Copy link
Author

jmclong commented Aug 10, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 7f34b3c into kubernetes-sigs:main_v2 Aug 10, 2022
@jmclong jmclong deleted the windows-build branch August 11, 2022 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants