Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V2] chore: add early return logic for scheduler filter / prioritize and update prioritize scoring logic #1448

Merged
merged 1 commit into from
Aug 5, 2022
Merged

[V2] chore: add early return logic for scheduler filter / prioritize and update prioritize scoring logic #1448

merged 1 commit into from
Aug 5, 2022

Conversation

sunpa93
Copy link
Contributor

@sunpa93 sunpa93 commented Aug 3, 2022

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 3, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 3, 2022
@edreed edreed requested review from landreasyan and removed request for andyzhangx August 3, 2022 01:10
@sunpa93 sunpa93 force-pushed the azdiskschedulerextender-early-return branch from f296556 to 396d2f4 Compare August 4, 2022 04:12
@sunpa93
Copy link
Contributor Author

sunpa93 commented Aug 4, 2022

/retest

@sunpa93 sunpa93 force-pushed the azdiskschedulerextender-early-return branch from 396d2f4 to 8327fac Compare August 5, 2022 01:33
@landreasyan
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2022
@sunpa93 sunpa93 force-pushed the azdiskschedulerextender-early-return branch from 8327fac to d869556 Compare August 5, 2022 02:33
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2022
@edreed
Copy link
Collaborator

edreed commented Aug 5, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edreed, sunpa93

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit b2ba4c1 into kubernetes-sigs:main_v2 Aug 5, 2022
@edreed edreed mentioned this pull request Aug 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edreed edreed edreed left review comments

@landreasyan landreasyan landreasyan left review comments

Assignees

@edreed edreed

@landreasyan landreasyan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunpa93 @landreasyan @edreed @k8s-ci-robot