Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V2] fix: Volume persistent-storage not csi error log #1446

Merged
merged 2 commits into from
Aug 3, 2022
Merged

[V2] fix: Volume persistent-storage not csi error log #1446

merged 2 commits into from
Aug 3, 2022

Conversation

shlokshah-dev
Copy link

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
[V2] Fix "Volume persistent-storage not csi" misclassified error log line

Which issue(s) this PR fixes:

Fixes #1416

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 2, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 2, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 2, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @shlokshah-dev!

It looks like this is your first PR to kubernetes-sigs/azuredisk-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/azuredisk-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @shlokshah-dev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2022
@shlokshah-dev
Copy link
Author

/cc @edreed
/cc @landreasyan
/cc @sunpa93

@shlokshah-dev
Copy link
Author

/assign

sunpa93
sunpa93 reviewed Aug 2, 2022
View reviewed changes
pkg/controller/common.go Outdated
@@ -565,8 +565,11 @@ func (c *SharedState) addPod(ctx context.Context, pod *v1.Pod, updateOption upda
}
namespacedClaimName := getQualifiedName(pod.Namespace, volume.PersistentVolumeClaim.ClaimName)
if _, ok := c.claimToVolumeMap.Load(namespacedClaimName); !ok {
w.Logger().V(5).Infof("Skipping Pod %s. Volume %s not csi. Driver: %+v", pod.Name, volume.Name, volume.CSI)
continue
// Log message if the Pod status is not Running
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log message if the Pod status is Running?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

pkg/controller/common.go Outdated
// Log message if the Pod status is not Running
if pod.Status.Phase == v1.PodRunning {
w.Logger().V(5).Infof("Skipping Pod %s. Volume %s not csi. Driver: %+v", pod.Name, volume.Name, volume.CSI)
continue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need this continue to be outside of if pod.Status.Phase == v1.PodRunning.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@landreasyan
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 2, 2022
@shlokshah-dev shlokshah-dev requested a review from sunpa93 August 2, 2022 18:24
@shlokshah-dev
Copy link
Author

/retest

@edreed edreed changed the title fix: Volume persistent-storage not csi error log [V2] fix: Volume persistent-storage not csi error log Aug 2, 2022
@edreed edreed removed the request for review from andyzhangx August 2, 2022 21:09
@edreed
Copy link
Collaborator

edreed commented Aug 2, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 2, 2022
sunpa93
sunpa93 approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@sunpa93 sunpa93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edreed, landreasyan, shlokshah-dev, sunpa93

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit c794dbe into kubernetes-sigs:main_v2 Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landreasyan landreasyan landreasyan approved these changes

@sunpa93 sunpa93 sunpa93 approved these changes

@nearora-msft nearora-msft Awaiting requested review from nearora-msft

@edreed edreed Awaiting requested review from edreed

Assignees

@edreed edreed

@shlokshah-dev shlokshah-dev

@sunpa93 sunpa93

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shlokshah-dev @k8s-ci-robot @landreasyan @edreed @sunpa93