Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V2] test: adding flag for replicas to run scale tests #1417

Merged
merged 1 commit into from
Jul 15, 2022
Merged

[V2] test: adding flag for replicas to run scale tests #1417

merged 1 commit into from
Jul 15, 2022

Conversation

chloeegong
Copy link

What type of PR is this?
/kind test

What this PR does / why we need it:
creating a flag to indicate the number of replicas to run scale tests

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 13, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @chloeegong. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 13, 2022
@k8s-ci-robot k8s-ci-robot requested review from edreed and ZeroMagic July 13, 2022 21:20
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 13, 2022
sunpa93
sunpa93 suggested changes Jul 13, 2022
View reviewed changes
pkg/azuredisk/azuredisk_v2.go Outdated
@@ -89,6 +92,25 @@ const (
azDriverNodeHealthy azDriverNodeStatus = "Driver node healthy."
)

// LatencyAdapter implements LatencyMetric.
type LatencyAdapter struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are part of #1410 so you should probably leave these changes our in this PR.

pkg/azureconstants/azure_constants.go Outdated
@@ -46,6 +46,7 @@ const (
FsTypeField = "fstype"
IncrementalField = "incremental"
KindField = "kind"
LatencyKey = "rate_limiter_throttling_request_latency_seconds"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as previous comment.

@chloeegong chloeegong force-pushed the t-chloeegong-replica-flags branch from 0a002ef to dd40b9c Compare July 13, 2022 21:28
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 13, 2022
landreasyan
landreasyan reviewed Jul 13, 2022
View reviewed changes
test/scale/azdisk_scale_test.go Outdated
@@ -46,6 +46,8 @@ func scaleTests(isMultiZone bool) {
schedulerName = testutil.GetSchedulerForE2E()
)

// handleFlags
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the comment.

landreasyan
landreasyan reviewed Jul 13, 2022
View reviewed changes
test/scale/flags.go Outdated
@@ -26,6 +26,7 @@ import (
var (
skipClusterBootstrap = flag.Bool("skip-cluster-bootstrap", false, "flag to indicate that we can skip cluster bootstrap.")
scaleTestTimeout = flag.Int("scale-test-timeout", 40, "flag to indicate the scale in and scale out test timeouts in minutes.")
testerReplica = flag.Int("tester-replica", 2, "flag to indicate the number of replicas for the scale tests.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default value should be 1000.

landreasyan
landreasyan reviewed Jul 13, 2022
View reviewed changes
test/scale/flags.go Outdated
@@ -26,6 +26,7 @@ import (
var (
skipClusterBootstrap = flag.Bool("skip-cluster-bootstrap", false, "flag to indicate that we can skip cluster bootstrap.")
scaleTestTimeout = flag.Int("scale-test-timeout", 40, "flag to indicate the scale in and scale out test timeouts in minutes.")
testerReplica = flag.Int("tester-replica", 2, "flag to indicate the number of replicas for the scale tests.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np: rename testerReplica to replicas or replica-count

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant to say that we need to rename the command line flag name, so tester-replica to replicas or replica-count instead of testerReplica

@chloeegong chloeegong force-pushed the t-chloeegong-replica-flags branch 2 times, most recently from 43ccfd9 to 9c9e709 Compare July 14, 2022 00:28
@chloeegong
adding replica flags to flags.go
1fda16a 
changing replica value

renaming replicas flag name

remove comments
@chloeegong chloeegong force-pushed the t-chloeegong-replica-flags branch from 9c9e709 to 1fda16a Compare July 14, 2022 17:19
@landreasyan
Copy link
Contributor

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 14, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2022
@edreed edreed removed the request for review from ZeroMagic July 14, 2022 17:29
@sunpa93
Copy link
Contributor

sunpa93 commented Jul 14, 2022

/retest

@edreed
Copy link
Collaborator

edreed commented Jul 14, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chloeegong, edreed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4d45e5c into kubernetes-sigs:main_v2 Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landreasyan landreasyan landreasyan left review comments

@sunpa93 sunpa93 sunpa93 requested changes

@edreed edreed Awaiting requested review from edreed

Assignees

@landreasyan landreasyan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chloeegong @k8s-ci-robot @landreasyan @sunpa93 @edreed