-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V2] fix: Fix CRI update on error recovery #1399
[V2] fix: Fix CRI update on error recovery #1399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edreed, sunpa93 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
5daab22
to
f858b4d
Compare
New changes are detected. LGTM label has been removed. |
/retest |
What type of PR is this?
/kind bug
/kind cleanup
/kind regression
What this PR does / why we need it:
azureutils.UpdateCRIWithRetry
and fix usage ofazureutils.AppendUpdateFunc
so that update functions are chained correctly. Update function chains are used on the operation error recovery path. The previous implementation wasn't chaining correctly and prevented retries of failed operations from succeeded.Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: