Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] fix: Fix CRI update on error recovery #1399

Merged

Conversation

edreed
Copy link
Collaborator

@edreed edreed commented Jun 25, 2022

What type of PR is this?

/kind bug
/kind cleanup

/kind regression

What this PR does / why we need it:

  1. Improves type safety of azureutils.UpdateCRIWithRetry and fix usage of azureutils.AppendUpdateFunc so that update functions are chained correctly. Update function chains are used on the operation error recovery path. The previous implementation wasn't chaining correctly and prevented retries of failed operations from succeeded.
  2. Ensures the final CRI status update occurs when the operation context is cancelled, or its deadline is exceeded.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@edreed edreed requested review from sunpa93 and nearora-msft June 25, 2022 22:43
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 25, 2022
@k8s-ci-robot k8s-ci-robot requested a review from ZeroMagic June 25, 2022 22:43
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 25, 2022
@edreed edreed removed the request for review from ZeroMagic June 25, 2022 22:44
Copy link
Contributor

@sunpa93 sunpa93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edreed, sunpa93

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@edreed
Copy link
Collaborator Author

edreed commented Jun 26, 2022

/retest

@edreed edreed force-pushed the edreed-fix-update-func-chaining branch from 5daab22 to f858b4d Compare June 26, 2022 02:01
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2022
@edreed
Copy link
Collaborator Author

edreed commented Jun 26, 2022

/retest

@edreed edreed merged commit a91aecf into kubernetes-sigs:main_v2 Jun 26, 2022
@edreed edreed deleted the edreed-fix-update-func-chaining branch June 26, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/regression Categorizes issue or PR as related to a regression from a prior release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants