Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] fix: Fix for intermittent failure for NodeStageVolume request #1395

Merged

Conversation

mukhoakash
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 24, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @mukhoakash. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from edreed and ZeroMagic June 24, 2022 21:10
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 24, 2022
@mukhoakash mukhoakash marked this pull request as ready for review June 24, 2022 21:11
@mukhoakash mukhoakash force-pushed the mukhoakash/fix_if_condition branch from 0a4bac5 to 8ae2cee Compare June 24, 2022 21:11
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2022
@edreed edreed requested review from sunpa93 and removed request for ZeroMagic June 24, 2022 21:12
Copy link
Contributor

@sunpa93 sunpa93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2022
@edreed edreed changed the title Fix for intermittent failure for NodeStageVolume request [V2] fix: Fix for intermittent failure for NodeStageVolume request Jun 24, 2022
@sunpa93
Copy link
Contributor

sunpa93 commented Jun 24, 2022

pull-azuredisk-csi-driver-e2e-migration-windows-mainv2 failed due to exceeding quota so will be retried once other tests complete.

@edreed
Copy link
Collaborator

edreed commented Jun 24, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 24, 2022
@mukhoakash
Copy link
Contributor Author

/retest

2 similar comments
@edreed
Copy link
Collaborator

edreed commented Jun 25, 2022

/retest

@edreed
Copy link
Collaborator

edreed commented Jun 25, 2022

/retest

@k8s-ci-robot
Copy link
Contributor

@mukhoakash: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azuredisk-csi-driver-external-e2e-single-az-mainv2 8ae2cee link true /test pull-azuredisk-csi-driver-external-e2e-single-az-mainv2

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@edreed
Copy link
Collaborator

edreed commented Jun 25, 2022

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edreed, mukhoakash, sunpa93

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2022
@edreed edreed merged commit 67b22f6 into kubernetes-sigs:main_v2 Jun 25, 2022
@mukhoakash mukhoakash deleted the mukhoakash/fix_if_condition branch June 25, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants