Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] fix: Add job ttl parameter to keep logs around after E2E tests complete #1393

Closed

Conversation

edreed
Copy link
Collaborator

@edreed edreed commented Jun 23, 2022

What type of PR is this?

/kind test
/king bug

What this PR does / why we need it:

Sets the ttlSecondsAfterFinished of the cleanup job to 5 minutes to keep the logs around after the E2E tests complete.

Which issue(s) this PR fixes:

Fixes #1392

Requirements:

Special notes for your reviewer:

Release note:

none

@edreed edreed requested a review from sunpa93 June 23, 2022 03:51
@k8s-ci-robot k8s-ci-robot added kind/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edreed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 23, 2022
@edreed edreed removed the request for review from ZeroMagic June 23, 2022 03:51
@edreed edreed changed the title fix: Add job ttl parameter to keep logs around after E2E tests complete [V2] fix: Add job ttl parameter to keep logs around after E2E tests complete Jun 23, 2022
@k8s-ci-robot
Copy link
Contributor

@edreed: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azuredisk-csi-driver-e2e-windows-mainv2 7636aa3 link true /test pull-azuredisk-csi-driver-e2e-windows-mainv2

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@edreed edreed closed this Jun 23, 2022
@edreed edreed deleted the edreed-add-cleanup-job-ttl branch June 23, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants