Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] feat: Skipping prioritize/(filter) extender processing for non-v2 disks #1389

Conversation

landreasyan
Copy link
Contributor

…V2 driver disks.

What type of PR is this?
Added on optimization in the extender to skip processing on prioritize and filter calls for non-v2 driver volumes. Currently, only prioritize is skipped until we fix #1097 in the controller but the functionality is added for both calls.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 22, 2022
@andyzhangx
Copy link
Member

@landreasyan is #1097 fixed or not?

@edreed edreed changed the title feat: Skipping prioritize/(filter) extender processing for non-v2 disks [V2] feat: Skipping prioritize/(filter) extender processing for non-v2 disks Jun 22, 2022
@landreasyan
Copy link
Contributor Author

@landreasyan is #1097 fixed or not?

@andyzhangx #1907 is fixed but we are changing the approach we took in the controller to prefer primary attachments over replicas which will eliminate the need of having this fix in the scheduler extender. Removing the fix for #1907 from the extender will make it completely non-blocking and in line with the expectations of the autoscaler.

@landreasyan landreasyan force-pushed the laandrea-az-scheduler-extender-optimization branch from 23d60d4 to 10c5469 Compare June 23, 2022 11:59
@landreasyan
Copy link
Contributor Author

/retest

@edreed
Copy link
Collaborator

edreed commented Jun 24, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edreed, landreasyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2022
@edreed
Copy link
Collaborator

edreed commented Jun 24, 2022

/retest

1 similar comment
@edreed
Copy link
Collaborator

edreed commented Jun 24, 2022

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants