-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V2] feat: Skipping prioritize/(filter) extender processing for non-v2 disks #1389
[V2] feat: Skipping prioritize/(filter) extender processing for non-v2 disks #1389
Conversation
@landreasyan is #1097 fixed or not? |
@andyzhangx #1907 is fixed but we are changing the approach we took in the controller to prefer primary attachments over replicas which will eliminate the need of having this fix in the scheduler extender. Removing the fix for #1907 from the extender will make it completely non-blocking and in line with the expectations of the autoscaler. |
23d60d4
to
10c5469
Compare
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edreed, landreasyan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
…V2 driver disks.
What type of PR is this?
Added on optimization in the extender to skip processing on prioritize and filter calls for non-v2 driver volumes. Currently, only prioritize is skipped until we fix #1097 in the controller but the functionality is added for both calls.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: