helm: use correct nodeSelector for k8s 1.25+

[jackfrancis]

What type of PR is this?

/kind failing-test
/kind api-change

What this PR does / why we need it:

This PR sets the correct nodeSelector in the helm chart so that it works with k8s 1.25+

Which issue(s) this PR fixes:

Fixes #

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Special notes for your reviewer:

Release note:

none

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jackfrancis
To complete the pull request process, please assign feiskyer after the PR has been reviewed.
You can assign the PR to them by writing /assign @feiskyer in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[marosset]

Should we add a new runOnControlPlane setting and have this line check if either is set and the apply the correct node-selector?

That is more work now but probably better in the long run.

[jackfrancis]

I think that would be a separate PR, but agree it would be good going forward.

@andyzhangx would you accept a follow-up PR with a new helm value controller.runOnControlPlane, with comment that controller.runOnMaster is deprecated?

[marosset]

fair enough

[andyzhangx]

I think we could remove controller.runOnMaster chart, replace with controller.runOnControlPlane directly

[jackfrancis]

Won't this break back-compat for existing users? (or has a new version of the chart w/ this configuration never been released?)

[andyzhangx]

that's ok for chart config of new versions, add a new controller.runOnControlPlane could be safer, and after a few versions, we could remove controller.runOnMaste

[jackfrancis]

how about we do that as a follow-up change? in the meantime looks like we can merge this to fix broken tests

[andyzhangx]

the windows test failure should already be fixed by #1362, no worry, I will provide a fix using controller.runOnControlPlane later

[andyzhangx]

PR(#1366) would address the issue.

[marosset]

/lgtm (pending tests)

[andyzhangx]

this PR should have fixed the test failure on 1.25+: #1362

[jackfrancis]

/retest

[k8s-ci-robot]

@jackfrancis: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-azuredisk-csi-driver-verify	332c43e	link	true	/test pull-azuredisk-csi-driver-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.