[V2] chore: DeleteVolume should wait for replicas to be fully deleted

[sunpa93]

instead of requeuing

What type of PR is this?
/kind chore

What this PR does / why we need it:

• AzVolume controller originally relied on reconciler requeue to wait for replica AzVolumeAttachment to be fully deleted but this can lead to huge backoffs causing a significant delay in volume deletion.
• This PR leverages condition watcher / waiter component to have AzVolume controller wait for the replica AzVolumeAttachments to be deleted to avoid over issuance of requeue
• And replaces existing polling in replica controller with event triggered waiter package.

Which issue(s) this PR fixes:

Fixes #

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Special notes for your reviewer:

Release note:

none

[k8s-ci-robot]

@sunpa93: The label(s) kind/chore cannot be applied, because the repository doesn't have them.

In response to this:

instead of requeuing

What type of PR is this?
/kind chore

What this PR does / why we need it:

• AzVolume controller originally relied on reconciler requeue to wait for replica AzVolumeAttachment to be fully deleted but this can lead to huge backoffs causing a significant delay in volume deletion.
• This PR leverages condition watcher / waiter component to have AzVolume controller wait for the replica AzVolumeAttachments to be deleted to avoid over issuance of requeue
• And replaces existing polling in replica controller with event triggered waiter package.

Which issue(s) this PR fixes:

Fixes #

Requirements:

• uses conventional commit messages

• includes documentation

• adds unit tests

• tested upgrade from previous version

Special notes for your reviewer:

Release note:

none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @sunpa93. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[edreed]

/ok-to-test

[sunpa93]

/retest

[edreed]

/retest

[edreed]

/retest

[edreed]

/approve
/lgtm

[edreed]

/retest

[sunpa93]

azuredisk-csi-driver/pkg/controller/replica.go

Lines 177 to 188 in 19bcb28

	err = wait.PollImmediateWithContext(ctx, deletionPollingInterval, 10*time.Minute, func(ctx context.Context) (bool, error) {
	azVolumeAttachmentList := &diskv1beta1.AzVolumeAttachmentList{}
	err := r.controllerSharedState.cachedClient.List(ctx, azVolumeAttachmentList, &listOptions)
	if err != nil {
	if errors.IsNotFound(err) {
	return true, nil
	}
	w.Logger().Errorf(err, "Failed to get AzVolumeAttachments.")
	return false, err
	}
	return len(azVolumeAttachmentList.Items) == 0, nil
	})

Probably can replace this polling with conditionWaiter

[sunpa93]

/test pull-azuredisk-csi-driver-external-e2e-single-az-mainv2

[sunpa93]

/test pull-azuredisk-csi-driver-external-e2e-single-az-mainv2

[sunpa93]

/test pull-azuredisk-csi-driver-external-e2e-single-az-mainv2

[edreed]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edreed, sunpa93

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [edreed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment