Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] Storage Analysis Tool for Azure Disk CSI Driver V2 #1277

Merged
merged 28 commits into from
Apr 25, 2022

Conversation

hccheng72
Copy link

@hccheng72 hccheng72 commented Apr 8, 2022

What type of PR is this?
/kind feature

What this PR does / why we need it:

  1. This tool to facilitate analysis and debugging of the Azure Disk CSI Driver in Kubernetes cluster.
  2. Reporting Azure Disk CSI Driver V2 persistent volumes information gathered by pod using information from its custom resources.
  3. Reporting Azure Disk CSI Driver V2 volume attachments information gathered by pod/node/zone using information from its custom resources.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:
Testing cases output:

az-analyze get
image
az-analyze get node
image
az-analyze get azv --pod <my-pod-name>
(if no specified namespace, default will be used)
image
az-analyze get azv
(show all azv in a table with a pod column)
image
az-analyze get azva --pod <my-pod-name>
(if no specified namespace, default will be used)
image
az-analyze get azva --node <my-node-name>
(if namespace is provided, it'll be ignored)
image
az-analyze get azva --zone <my-zone-name>
(if namespace is provided, it'll be ignored)
image
az-analyze get azva
(show all azva in a table with pod, node and zone as columns)
image
az-analyze get azva --pod
(empty argument for pod/node/zone flag will cause an error)
image
az-analyze -h
image

Release note:

none

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 8, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 8, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @hccheng72!

It looks like this is your first PR to kubernetes-sigs/azuredisk-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/azuredisk-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @hccheng72. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 8, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 8, 2022
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
could you add a unit test and build test in this PR?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 9, 2022
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 11, 2022
@edreed edreed changed the title Storage cli [V2] Storage cli Apr 11, 2022
@edreed
Copy link
Collaborator

edreed commented Apr 11, 2022

/assign @nearora-msft

pkg/tool/az-analyze/LICENSE Outdated Show resolved Hide resolved
@edreed edreed changed the title [V2] Storage cli [V2] Storage Analysis Tool for Azure Disk CSI Driver V2 Apr 11, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 21, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 21, 2022
@nearora-msft
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hccheng72, nearora-msft

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit ed3ee08 into kubernetes-sigs:main_v2 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants