Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] allow multiple targetgroupbindings to reference same tg arn if using multicluster mode #4021

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zac-nixon
Copy link
Collaborator

@zac-nixon zac-nixon commented Jan 16, 2025

Issue

n/a

Description

Users would like to utilize the same Target Group ARN for multiple TargetGroupBindings. Previously, before Multicluster support, this was not possible as the reconcile logic would be unaware of other entities registering targets into the configured Target Group. Now, using Multicluster TargetGroupBindings, the reconcile logic is able to only operate on targets in the Target Group that belong to the specified TargetGroupBinding.

We can relax the validation logic to allow users to specify duplicate Target Group ARNs if they also specify the Multicluster flag on each binding.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zac-nixon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 16, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 16, 2025
@zac-nixon zac-nixon force-pushed the znixon/mc-same-cluster branch from 6d1a33c to d118858 Compare January 16, 2025 21:55
@zac-nixon
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants