Expose ingress configuration options for missing backends #3342

kc9ddi · 2023-08-16T16:53:24Z

Issue

This PR fixes #3330

Description

This PR adds command line flags to specify whether the the controller should tolerate missing backend services and actions. If the flags are not specified, the default value will be to tolerate missing backend actions and services (which is the current behavior.)

The code changes here are simply to thread these values through to enhanced_backend_builder.go, and rely on them rather than using the defaultTolerateNonExistentBackendService and defaultTolerateNonExistentBackendAction constant fields. The logic here is already unit tested, so no new tests have been added.

Checklist

Added tests that cover your change (if possible)
Added/modified documentation as required (such as the README.md, or the docs directory)
Manually tested
Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

Backfilled missing tests for code in same general area 🎉
Refactored something and made the world a better place 🌟

This PR adds command line flags to specify whether the the controller should tolerate missing backend services and actions. If the flags are not specified, the default value will be to tolerate missing backend actions and services (which is the current behavior.) The code changes here are simply to thread these values through to `enhanced_backend_builder.go`, and rely on them rather than using the `defaultTolerateNonExistentBackendService` and `defaultTolerateNonExistentBackendAction` constant fields. The logic here is already unit tested, so no new tests have been added.

linux-foundation-easycla · 2023-08-16T16:53:28Z

The committers listed above are authorized under a signed CLA.

✅ login: kc9ddi / name: Patrick McDonnell (7fcab82, 84c192e)

k8s-ci-robot · 2023-08-16T16:53:32Z

Welcome @kc9ddi!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-08-16T16:53:33Z

Hi @kc9ddi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kc9ddi · 2023-08-30T16:13:47Z

Hi @M00nF1sh and @oliviassss, I just wanted to confirm that review of this PR isn't waiting on me for anything?

helm/aws-load-balancer-controller/templates/deployment.yaml

oliviassss · 2023-09-04T15:43:33Z

/ok-to-test

kc9ddi · 2023-09-06T14:40:48Z

/retest-required

oliviassss · 2023-09-07T20:11:22Z

/lgtm
/assign @M00nF1sh

codecov-commenter · 2023-09-19T00:10:28Z

Codecov Report

Patch coverage: 55.55% and project coverage change: +0.11% 🎉

Comparison is base (aa893b5) 55.61% compared to head (84c192e) 55.73%.
Report is 44 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3342      +/-   ##
==========================================
+ Coverage   55.61%   55.73%   +0.11%     
==========================================
  Files         149      149              
  Lines        8819     8831      +12     
==========================================
+ Hits         4905     4922      +17     
+ Misses       3577     3575       -2     
+ Partials      337      334       -3

Files Changed	Coverage Δ
pkg/config/ingress_config.go	`0.00% <0.00%> (ø)`
pkg/ingress/enhanced_backend_builder.go	`90.32% <100.00%> (ø)`

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

M00nF1sh

/lgtm
/approve

k8s-ci-robot · 2023-10-16T17:30:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kc9ddi, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [M00nF1sh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

oliviassss · 2023-10-16T17:32:42Z

/retest

…-sigs#3342) * Expose configuration for missing backends This PR adds command line flags to specify whether the the controller should tolerate missing backend services and actions. If the flags are not specified, the default value will be to tolerate missing backend actions and services (which is the current behavior.) The code changes here are simply to thread these values through to `enhanced_backend_builder.go`, and rely on them rather than using the `defaultTolerateNonExistentBackendService` and `defaultTolerateNonExistentBackendAction` constant fields. The logic here is already unit tested, so no new tests have been added. * add new settings to values.yaml

…lity Merge in DEL/aws-load-balancer-controller-fork from IENGOC-39 to main * commit '3e26f86e82a5d419a7f8adfc5c95dd45984be6f4': IENGOC-39: Remediate more bd vulnerabilities IENGOC-39: Remediate bd vulnerabilities cut v2.6.2 release (kubernetes-sigs#3453) update ci e2e script for cert IDs (kubernetes-sigs#3392) fix test failure doc updates (kubernetes-sigs#3426) Change of text "your-cluster-name" (kubernetes-sigs#3152) slice init style suggestion whitespace group errors, emit one event per reconcile, requeue on failure don't block TGB reconciliation loop on failed SG ingress reconciliation fix: remove service from function args feat: resolve health check port name for NLB Expose ingress configuration options for missing backends (kubernetes-sigs#3342) Stricter dependency/security review remove unnecessary patch requests (kubernetes-sigs#3380) increase timeout to 2h in ci scripts wait for the TG to be healthy before cleanup any resource

k8s-ci-robot requested review from M00nF1sh and oliviassss August 16, 2023 16:53

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 16, 2023

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 16, 2023

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 16, 2023

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 24, 2023

oliviassss reviewed Aug 31, 2023

View reviewed changes

helm/aws-load-balancer-controller/templates/deployment.yaml Show resolved Hide resolved

add new settings to values.yaml

84c192e

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 4, 2023

k8s-ci-robot assigned M00nF1sh and oliviassss Sep 7, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2023

M00nF1sh approved these changes Oct 16, 2023

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2023

oliviassss added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 16, 2023

oliviassss merged commit 36c6c4f into kubernetes-sigs:main Oct 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expose ingress configuration options for missing backends #3342

Expose ingress configuration options for missing backends #3342

kc9ddi commented Aug 16, 2023 •

edited

Loading

linux-foundation-easycla bot commented Aug 16, 2023 •

edited

Loading

k8s-ci-robot commented Aug 16, 2023

k8s-ci-robot commented Aug 16, 2023

kc9ddi commented Aug 30, 2023

oliviassss commented Sep 4, 2023

kc9ddi commented Sep 6, 2023

oliviassss commented Sep 7, 2023

codecov-commenter commented Sep 19, 2023

M00nF1sh left a comment

k8s-ci-robot commented Oct 16, 2023

oliviassss commented Oct 16, 2023

Expose ingress configuration options for missing backends #3342

Expose ingress configuration options for missing backends #3342

Conversation

kc9ddi commented Aug 16, 2023 • edited Loading

Issue

Description

Checklist

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

linux-foundation-easycla bot commented Aug 16, 2023 • edited Loading

k8s-ci-robot commented Aug 16, 2023

k8s-ci-robot commented Aug 16, 2023

kc9ddi commented Aug 30, 2023

oliviassss commented Sep 4, 2023

kc9ddi commented Sep 6, 2023

oliviassss commented Sep 7, 2023

codecov-commenter commented Sep 19, 2023

Codecov Report

M00nF1sh left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Oct 16, 2023

oliviassss commented Oct 16, 2023

kc9ddi commented Aug 16, 2023 •

edited

Loading

linux-foundation-easycla bot commented Aug 16, 2023 •

edited

Loading