Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update recommended IAM policy template #3068

Merged
merged 1 commit into from
Feb 23, 2023
Merged

update recommended IAM policy template #3068

merged 1 commit into from
Feb 23, 2023

Conversation

jdn5126
Copy link
Contributor

@jdn5126 jdn5126 commented Feb 20, 2023 •
edited
Loading

Issue

Fixes: #2692

Description

This PR updates the recommended IAM policy template to add an explicit elasticloadbalancing:AddTags permission for create resources.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 20, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 20, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @jdn5126. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 20, 2023
@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 20, 2023
@kishorj
Copy link
Collaborator

kishorj commented Feb 20, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 20, 2023
kishorj
kishorj reviewed Feb 20, 2023
View reviewed changes
docs/install/iam_policy_us-gov.json Outdated Show resolved Hide resolved
docs/install/iam_policy_us-gov.json Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023 •
edited
Loading

Codecov Report

Base: 54.32% // Head: 54.32% // No change to project coverage 👍

Coverage data is based on head (63b9ed1) compared to base (3caec46).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3068   +/-   ##
=======================================
  Coverage   54.32%   54.32%           
=======================================
  Files         145      145           
  Lines        8410     8410           
=======================================
  Hits         4569     4569           
  Misses       3511     3511           
  Partials      330      330

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

sftim
sftim reviewed Feb 22, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just AddTags? What about removals, do those ever need to happen?

@kishorj
Copy link
Collaborator

kishorj commented Feb 22, 2023

Just AddTags? What about removals, do those ever need to happen?

This additional permission is for the tag elbv2.k8s.aws/cluster on create. Once this tag is set, current iam permissions already permit adding/removing other tags. This tag stays put for the life of the resource.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jdn5126, kishorj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2023
@kishorj
Copy link
Collaborator

kishorj commented Feb 23, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9333126 into kubernetes-sigs:main Feb 23, 2023
This was referenced Apr 14, 2023
Closed
Merged
@Nuru Nuru mentioned this pull request May 24, 2023
Merged
@chjtwork chjtwork mentioned this pull request May 30, 2023
Closed
@Himangini Himangini mentioned this pull request May 30, 2023
Merged
7 tasks
@sink-opuba sink-opuba mentioned this pull request Jul 19, 2023
Closed
johngmyers pushed a commit to johngmyers/aws-load-balancer-controller that referenced this pull request Aug 21, 2023
@guildencrantz
Pull request kubernetes-sigs#1: DELIVERY-8202 pull upstream
2e1239a 
Merge in DEL/aws-load-balancer-controller-fork from DELIVERY-8202_pull_upstream to main

* commit '49805eac72ec533acdbc2580d6f57c68a9cad45c':
  update the default base image (kubernetes-sigs#3075)
  update recommended IAM policy template (kubernetes-sigs#3068)
  update to discovery.k8s.io/v1 (kubernetes-sigs#3072)
  validation ingress condition annotation in validation webhook (kubernetes-sigs#2735)
  Fix conciseLogger's incorrect call to variadic func (kubernetes-sigs#3066)
  Verify CRDs are up to date in merge check (kubernetes-sigs#3022)
  Refactor model builder test (kubernetes-sigs#3024)
@oliviassss oliviassss mentioned this pull request Sep 7, 2023
Closed
4 tasks
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
@jdn5126 @Timothy-Dougherty
update recommended IAM policy template (kubernetes-sigs#3068)
b12a979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@kishorj kishorj kishorj approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees

@kishorj kishorj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing to create target group with default policy
5 participants
@jdn5126 @k8s-ci-robot @kishorj @codecov-commenter @sftim