Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect ingress lock held by (other) controller #203

Closed
joshrosso opened this issue Sep 13, 2017 · 3 comments
Closed

Respect ingress lock held by (other) controller #203

joshrosso opened this issue Sep 13, 2017 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@joshrosso
Copy link

Based on log observation, I believe we are not respecting the ingress lock today. As seen below.

Failed to update lock: Operation cannot be fulfilled on configmaps "ingress-controller-leader-alb": the object has been modified; please apply your changes to the latest version and try again

We should look into this and make sure we're not letting a second deployment of the controller stomp over another.
@joshrosso joshrosso added the kind/bug Categorizes issue or PR as related to a bug. label Sep 13, 2017
@aledbf
Copy link
Member

aledbf commented Sep 13, 2017

@joshrosso this is fixed in master of kubernetes/ingress here kubernetes/ingress-nginx#1338

@joshrosso
Copy link
Author

@aledbf Thanks. Will upgrade ingress library and test.

joshrosso added a commit that referenced this issue Sep 14, 2017
@joshrosso
Update ingress version to b2ad9e7
b30d8d2 
- Due to issue acquiring lock with multiple controller, we need to
update the ingress library. With this upgrade comes a new interface
method GetEndpoints(). Since we do not utilize a default endpoint, it
just returns an empty Endpoint struct.

- Resolves #203
@joshrosso
Copy link
Author

joshrosso commented Sep 14, 2017 •
edited
Loading

Ingress library updated and no longer seeing issue in logs.

xref: b30d8d2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aledbf @joshrosso