-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why not use a deployment's readinessProbe for healthchecks? #1269
Comments
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'm also confused about the duplication of K8s health checks and those defined as annotations. |
/reopen |
@sergeyshevch: You can't reopen an issue/PR unless you authored it or you are a collaborator. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
would one of the contributors please comment on whether this is feasible? We pretty much duplicate our readinessProb config to health check annotations. It would be nice to streamline it, make it more k8s native perhaps. In my opinion the annotations are always meant for functionality additional to the spec, but readinessProbes already exist in the spec for the same purpose. |
I tried doing some searching and didn't find much, so forgive me if this gets asked a lot.
Is it possible to use a deployment's readinessProbe instead of defining healthcheck annotations on the Ingress object?
It seems like there's an unnecessary duplication of the healthcheck path/port when the information is already available through the K8s API.
It would be cool to see annotations something like
The text was updated successfully, but these errors were encountered: