Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not use a deployment's readinessProbe for healthchecks? #1269

Closed
clayvan opened this issue May 20, 2020 · 8 comments
Closed

Why not use a deployment's readinessProbe for healthchecks? #1269

clayvan opened this issue May 20, 2020 · 8 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@clayvan
Copy link

clayvan commented May 20, 2020

I tried doing some searching and didn't find much, so forgive me if this gets asked a lot.

Is it possible to use a deployment's readinessProbe instead of defining healthcheck annotations on the Ingress object?

It seems like there's an unnecessary duplication of the healthcheck path/port when the information is already available through the K8s API.

It would be cool to see annotations something like

alb.ingress.kubernetes.io/healthcheck-path: use-readiness-probe
alb.ingress.kubernetes.io/healthcheck-port: use-readiness-probe
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 17, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vnugent
Copy link

vnugent commented Jul 2, 2021

I'm also confused about the duplication of K8s health checks and those defined as annotations.

@sergeyshevch
Copy link

/reopen
I also guess that we can just use k8s readiness probe (if it exists) that contain same health check functional.
I can work on it if someone can tell more about reasons of this behaviour

@k8s-ci-robot
Copy link
Contributor

@sergeyshevch: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen
I also guess that we can just use k8s readiness probe (if it exists) that contain same health check functional.
I can work on it if someone can tell more about reasons of this behaviour

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gazal-k
Copy link

gazal-k commented Feb 1, 2023

would one of the contributors please comment on whether this is feasible? We pretty much duplicate our readinessProb config to health check annotations. It would be nice to streamline it, make it more k8s native perhaps. In my opinion the annotations are always meant for functionality additional to the spec, but readinessProbes already exist in the spec for the same purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

6 participants