Documentation for adding AWS_PROFILE #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asobrien
force-pushed
the
feature/enable_profiles
branch
from
a3b0fcc to
2748b56
Compare
|
@asobrien check the issue for feedback… I would say change this and the title to Documentation for adding |
Fixes kubernetes-sigs#94 Signed-off-by: Anthony O'Brien [email protected]
asobrien
force-pushed
the
feature/enable_profiles
branch
from
2748b56 to
6586238
Compare
asobrien
changed the title
|
@christopherhein I've updated the PR so that it just adds documentation that covers specifying credentials and using a |
|
Awesome @asobrien LGTM. @nckturner any chance you can give this a quick review? |
|
@christopherhein Yup taking a look |
nckturner
approved these changes
Jun 8, 2018
|
The travis issue … looks like a flake? Then again the |
Signed-off-by: Anthony O'Brien <[email protected]>
asobrien
force-pushed
the
feature/enable_profiles
branch
from
47139cb to
766fe3e
Compare
|
@christopherhein I added a |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94
Signed-off-by: Anthony O'Brien [email protected]