Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stderr instead of stdout for MFA prompt #74

Merged
merged 1 commit into from
Apr 12, 2018
Merged

Use stderr instead of stdout for MFA prompt #74

merged 1 commit into from
Apr 12, 2018

Conversation

nckturner
Copy link
Contributor

These changes send the MFA prompt through stderr instead of stdout. This allows for use with kubectl 1.10 exec-based auth provider, which expects formatted JSON on stdout. Tested with kubectl 1.10:

$ ./test/kubectl-v1.10 --kubeconfig test/mfa.conf get pods 
Assume Role MFA token code: 681612
No resources found.

Signed-off-by: Nick Turner [email protected]

mattmoyer
mattmoyer approved these changes Apr 12, 2018
View reviewed changes
Copy link
Contributor

@mattmoyer mattmoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nckturner nckturner merged commit 55067d3 into kubernetes-sigs:master Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoyer mattmoyer mattmoyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nckturner @mattmoyer