aws-iam-authenticator version returns empty output

[keithlayne]

$ go get -u -v github.com/kubernetes-sigs/aws-iam-authenticator/cmd/aws-iam-authenticator                                     
github.com/kubernetes-sigs/aws-iam-authenticator (download)

$ cd $GOPATH/src/github.com/kubernetes-sigs/aws-iam-authenticator && git show 
commit 82544ec86140b7027a07890b09c2f03fca97228a (HEAD -> master, tag: 0.4.0-alpha.1, origin/master, origin/HEAD)
Merge: eb0b44b 96243fb
Author: k8s-ci-robot <[email protected]>
Date:   Thu Oct 18 19:40:09 2018 -0700

    Merge pull request #167 from nckturner/github-owner

    Change github repository

$ aws-iam-authenticator version  
{}

[keithlayne]

/kind bug

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[keithlayne]

Thanks, bot. I'm glad at least you are paying attention.

[keithlayne]

/remove-lifecycle stale

[nckturner]

Can you verify this is fixed for you in the newest version with: #187

Essentially the version is only set when its built with the correct ldflags:

# .goreleaser.yaml:
    ldflags:
      - "-s -w -X main.version={{.Version}} -X main.commit={{.Commit}}"

It could probably be improved by using a short git hash with a dirty tag like git-9999cd80-dirty if you want to submit a PR.

[keithlayne]

Sorry for snarking, I should have checked through issues and PRs when I got pinged by the bot. I wish this issue was linked in that one before now.

I confirm that #187 works as advertised when run against a version built with go get. Thanks for that!

I think part of the problem (separate issue) is that there is only one place that mentions installation in the README: toward the bottom of this section. Also, at the time I created this issue, the latest release was pretty far behind master IIRC. Either way, a prominent section in the readme about installation options showing both the dl/chmod/cp stuff and go get would be helpful IMO.

/close

[k8s-ci-robot]

@keithlayne: Closing this issue.

In response to this:

Sorry for snarking, I should have checked through issues and PRs when I got pinged by the bot. I wish this issue was linked in that one before now.

I confirm that #187 works as advertised when run against a version built with go get. Thanks for that!

I think part of the problem (separate issue) is that there is only one place that mentions installation in the README: toward the bottom of this section. Also, at the time I created this issue, the latest release was pretty far behind master IIRC. Either way, a prominent section in the readme about installation options showing both the dl/chmod/cp stuff and go get would be helpful IMO.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[heidemn]

@nckturner The AWS docs should be updated and provide a download link to a binary printing the correct version number.
https://docs.aws.amazon.com/eks/latest/userguide/install-aws-iam-authenticator.html

Using the provided Linux download link, I still get {} as version.
curl -o aws-iam-authenticator https://amazon-eks.s3-us-west-2.amazonaws.com/1.12.7/2019-03-27/bin/linux/amd64/aws-iam-authenticator