Modularize the controller and node services #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
hughdanliu
force-pushed
the
modularize-services
branch
3 times, most recently
from
2bd8af2 to
c7e5b91
Compare
k8s-ci-robot
added
the
needs-rebase
hughdanliu
force-pushed
the
modularize-services
branch
from
c7e5b91 to
47269af
Compare
k8s-ci-robot
removed
the
needs-rebase
hughdanliu
force-pushed
the
modularize-services
branch
from
47269af to
2a6ac81
Compare
| func main() { | ||
| fs := flag.NewFlagSet("aws-fsx-csi-driver", flag.ExitOnError) | ||
|
|
||
| if err := logsapi.RegisterLogFormat(logsapi.JSONLogFormat, json.Factory{}, logsapi.LoggingBetaOptions); err != nil { |
There was a problem hiding this comment.
let's remove this and add make it a separate commit supporting json, like this one: kubernetes-sigs/aws-fsx-csi-driver@e86f25e and also come of the changes in here:
kubernetes-sigs/aws-fsx-csi-driver@770a2c6
hughdanliu
force-pushed
the
modularize-services
branch
from
2a6ac81 to
9ba0a59
Compare
hughdanliu
force-pushed
the
modularize-services
branch
from
9ba0a59 to
a3bd097
Compare
hughdanliu
force-pushed
the
modularize-services
branch
from
33427e6 to
cc7f631
Compare
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hughdanliu, jacobwolfaws The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
Refactor for future features. Allows us to add flags to the controller/node services and adds support for JSON logging.
What is this PR about? / Why do we need it?
Modularizes the controller and node services. This refactor will allow us to support node start-up taints, driver service deployment options, and makes our implementation consistent with EBS/FSx for Lustre.
Also configures JSON logging and text (default) logging options for the CSI driver.
What testing is done?
Ran unit tests via
make testand ran sanity tests viamake test-sanityPerformed various rounds of manual testing to ensure functionality was kept intact.