Parameterise tolerations and securityContext

[BrunoChauvet]

Is this a bug fix or adding new feature?

Better control of tolerations is required when all nodes in a cluster have taints with effect NoExecute.
Fixes #305

What is this PR about? / Why do we need it?

This PR gives better control over tolerations so they can be entirely replaced with custom ones.
The same level of customisation is applied to securityContext.

Note that this follows the same conventions as aws-ebs-csi-driver
Controller: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/charts/aws-ebs-csi-driver/templates/controller.yaml#L43
Daemonset: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/charts/aws-ebs-csi-driver/templates/node.yaml#L39

What testing is done?

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: BrunoChauvet / name: Bruno Chauvet (4afe9d9)

[k8s-ci-robot]

Welcome @BrunoChauvet!

It looks like this is your first PR to kubernetes-sigs/aws-fsx-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-fsx-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @BrunoChauvet. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BrunoChauvet
Once this PR has been reviewed and has the lgtm label, please assign jacobwolfaws for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[olemarkus]

You also intend parameterising topologyspreadconstraints?

[olemarkus]

/ok-to-test

[k8s-ci-robot]

@BrunoChauvet: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-aws-fsx-csi-driver-e2e	5b5f3d0	link	true	/test pull-aws-fsx-csi-driver-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jacobwolfaws]

Can this be squashed into one PR prior to merging? Once you've squashed it I'll rerun the testing

[jacobwolfaws]

also please increase the helm image version to 1.5.2 in the Chart.yaml & update the changelog, which will automatically release a new helm chart (and thus allow you to use the new helm chart). Here's an example of a recent PR I did: 433d653

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jacobwolfaws]

Tolerations were parametrized in this PR: #311. We don't currently support topology, please open a new PR to 1) add topology support or 2) parameterize securityContext. Thanks!

[jacobwolfaws]

/close

[k8s-ci-robot]

@jacobwolfaws: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.