Move interfaces to _interface.go files and generate mocks from them

[wongma7]

Is this a bug fix or adding new feature? refactoring

What is this PR about? / Why do we need it? housekeeping/refactoring to make pkg/cloud better resemble EBS https://github.com/kubernetes-sigs/aws-ebs-csi-driver/tree/master/pkg/cloud after the EBS PRs kubernetes-sigs/aws-ebs-csi-driver#1074 and kubernetes-sigs/aws-ebs-csi-driver#1078. Ultimately I want to copy the metadata_k8s solution and its associated tests (e2e + unit) from EBS into this repo so this is just some quick refactoring to prepare for that.

EBS:

$ tree pkg/cloud/
pkg/cloud/
├── aws_metrics.go
├── cloud.go
├── cloud_interface.go
├── cloud_test.go
├── devicemanager
│   ├── allocator.go
│   ├── allocator_test.go
│   ├── manager.go
│   └── manager_test.go
├── ec2_interface.go
├── handlers.go
├── metadata_ec2.go
├── metadata.go
├── metadata_interface.go
├── metadata_k8s.go
├── metadata_test.go
├── mock_cloud.go
├── mock_ec2.go
└── mock_metadata.go

1 directory, 18 files

EFS:

$ tree pkg/cloud
pkg/cloud
├── cloud.go
├── cloud_interface.go
├── cloud_test.go
├── efs_interface.go
├── fakes.go
├── metadata_ecs.go
├── metadata_ecs_test.go
├── metadata.go
├── metadata_interface.go
├── metadata_test.go
├── mock_cloud.go
├── mock_efs.go
└── mock_metadata.go

0 directories, 13 files

It is unclear the need for a generic "Cloud" interface and how that differs from the "EFS" interface. Likewise for the EBS "Cloud" https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/pkg/cloud/cloud_interface.go and "EC2" https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/pkg/cloud/ec2_interface.go. We may eventually put pkg/cloud in its own repo or move it to cloud-provider repo so that it can be consumable from all csi drivers without code duplication. In which case we will have to sort out this "Cloud"/cloud.go/cloud_interface.go conflict. But for now I do not see much reason to invest in this because EFS pkg/cloud and EBS pkg/cloud should be free to develop independently/selfishly. The metadata solution is the first and only thing we have found that should be shared... Once more things come up then we should think about putting them in a repo to avoid copy/paste.

What testing is done? make test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wongma7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nckturner]

Seems like a reasonable approach.
/lgtm

[wongma7]

/retest

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[wongma7]

/test pull-aws-efs-csi-driver-verify

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[wongma7]

/lifecycle frozen

[k8s-ci-robot]

@wongma7: The lifecycle/frozen label cannot be applied to Pull Requests.

In response to this:

/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wongma7]

/remove-lifecycle rotten

[k8s-ci-robot]

@wongma7: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-aws-efs-csi-driver-external-test-eks	f85ed37	link	true	/test pull-aws-efs-csi-driver-external-test-eks

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

@wongma7: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.