Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast-forward to latest ebs hack/e2e scripts with eksctl support, k8s 1.20, etc. #510

Merged
merged 2 commits into from
Jul 14, 2021

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Jul 13, 2021

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it?
I applied the latest version of scripts from https://github.com/kubernetes-sigs/aws-ebs-csi-driver/tree/master/hack/e2e

git fetch ebs                                                                  
git diff HEAD:hack/e2e ebs/master:hack/e2e > /tmp/hack_e2e.diff                
git apply --reject --directory hack/e2e /tmp/hack_e2e.diff
git commit

What testing is done?
scripts work in ebs repo, will let CI test if they continue to work in this one.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from d-nishi and justinsb July 13, 2021 21:52
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 13, 2021
@nckturner
Copy link
Contributor

nckturner commented Jul 14, 2021

So are they copied from the EBS repository with slight modifications? Don't we use submodules to avoid copying scripts? (Should we start moving some shared scripts, like the eksctl, to https://github.com/kubernetes-sigs/provider-aws-test-infra?)

@wongma7
Copy link
Contributor Author

wongma7 commented Jul 14, 2021

@nckturner there are no modifications, see the commands i did in the pr test. submodules doesn't work well for copying a subdirectory, that's why i use read-tree and the commands i did.

@nckturner
Copy link
Contributor

Ok, Not sure exactly what you mean, I think we can probably solve this by moving anything that is the same to the test-infra respository but I'm not going to block on that.

@nckturner
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2b75682 into kubernetes-sigs:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants