-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify delete access point root directory logic to only remove temporary directory if empty #1532
Modify delete access point root directory logic to only remove temporary directory if empty #1532
Conversation
Hi @jrakas-dev. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/lgtm |
/retest-required |
1d280af
to
4843be4
Compare
…ary directory if empty
7cee4f4
to
7693a4e
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrakas-dev, mskanth972, wangnyue The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
Addresses issues encountered in
What is this PR about? / Why do we need it?
To delete the access point root directory when
delete-access-point-root-dir
is set totrue
, the controller mounts the EFS file system to a temporary directory and deletes the corresponding access point directory from there. This PR ensures that this temporary directory is unmounted and empty before proceeding to delete the temporary directory as part of it's cleanup process.What testing is done?
We came up with a workload that is able to consistently and quickly reproduce the issue in #1085. We ran extensive experiments with and without the fix and found the fix in this PR works to prevent the issue from occurring.