Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix controller.podLabels typo in values.yaml #1445

Merged

Conversation

pvickery-ParamountCommerce
Copy link
Contributor

@pvickery-ParamountCommerce pvickery-ParamountCommerce commented Aug 26, 2024

Is this a bug fix or adding new feature?
This fixes a typo in values.yaml which can cause confusion.
controller.podLabel -> controller.podLabels

What is this PR about? / Why do we need it?

What testing is done?
Searching for the use of .Values.controller.podLabel
https://github.com/search?q=repo%3Akubernetes-sigs%2Faws-efs-csi-driver%20controller.podLabels&type=code

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 26, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @pvickery-ParamountCommerce!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 26, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @pvickery-ParamountCommerce. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 26, 2024
@pvickery-ParamountCommerce
Copy link
Contributor Author

@mskanth972 Would you be able to review this super small PR?

@mskanth972
Copy link
Contributor

Looks good to me, can you squash the commits so that I can merge?

@pvickery-ParamountCommerce
Copy link
Contributor Author

pvickery-ParamountCommerce commented Oct 22, 2024

Great thanks! I've finished the rebase

@mskanth972 in case you didn't get a notification

@mskanth972
Copy link
Contributor

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 22, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2024
@pvickery-ParamountCommerce
Copy link
Contributor Author

@mskanth972 The tests have completed, can you approve to add the label?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2024
@pvickery-ParamountCommerce
Copy link
Contributor Author

@mskanth972 can we get this merged?

@mskanth972
Copy link
Contributor

/ok-to-test

@mskanth972
Copy link
Contributor

mskanth972 commented Nov 11, 2024

@mskanth972 can we get this merged?

Sure, will merge once the above tests are done.

@pvickery-ParamountCommerce
Copy link
Contributor Author

/test pull-aws-efs-csi-driver-unit

@pvickery-ParamountCommerce
Copy link
Contributor Author

I noticed there is another PR for this change
@bart-braidwell #1442

@pvickery-ParamountCommerce
Copy link
Contributor Author

@mskanth972 tests have now passed. The pull-aws-efs-csi-driver-unit strangely failed but passed when I ran it again so I think the test is flaky.

@mskanth972
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mskanth972, pvickery-ParamountCommerce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit dad9553 into kubernetes-sigs:master Nov 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants