-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix controller.podLabels typo in values.yaml #1445
Fix controller.podLabels typo in values.yaml #1445
Conversation
Welcome @pvickery-ParamountCommerce! |
Hi @pvickery-ParamountCommerce. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@mskanth972 Would you be able to review this super small PR? |
Looks good to me, can you squash the commits so that I can merge? |
76e2529
to
b1efe26
Compare
Great thanks! I've finished the rebase @mskanth972 in case you didn't get a notification |
/ok-to-test |
@mskanth972 The tests have completed, can you approve to add the label? |
b1efe26
to
5d686e8
Compare
@mskanth972 can we get this merged? |
/ok-to-test |
Sure, will merge once the above tests are done. |
/test pull-aws-efs-csi-driver-unit |
I noticed there is another PR for this change |
@mskanth972 tests have now passed. The |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mskanth972, pvickery-ParamountCommerce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
This fixes a typo in values.yaml which can cause confusion.
controller.podLabel
->controller.podLabels
What is this PR about? / Why do we need it?
What testing is done?
Searching for the use of
.Values.controller.podLabel
https://github.com/search?q=repo%3Akubernetes-sigs%2Faws-efs-csi-driver%20controller.podLabels&type=code