-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make sure the startup taint will eventually being removed after efs driver ready #1287
make sure the startup taint will eventually being removed after efs driver ready #1287
Conversation
Welcome @abbshr! |
Hi @abbshr. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Thank you for raising this PR @abbshr , as mentioned by the bot above, please follow the CLA authorization process here: #1287 (comment) Believe this PR should address the following issue: #1320 |
Hello, anything I can help do in order to get this merged? We have experienced the taint not being cleared in our clusters and have a temp hack in place to mitigate the issue. We would love to use this fix instead! |
Signed CLA~ |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abbshr, seanzatzdev-amazon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When will this get released? |
@mskanth972 Done |
Even with the latest efs-csi-driver version we're still getting lingering taints even though the driver logs state that the taints were removed. |
Is this a bug fix or adding new feature?
bug fix
What is this PR about? / Why do we need it?
removeNotReadyTaint()
just call one time, so there may be accident the taint didn't remove successfully,lead to node unschedulable for the pod can't tolerate the taint, this PR make sure the startup taint will eventually being removed after efs driver ready.
What testing is done?
test the compensation mechanism