Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure the startup taint will eventually being removed after efs driver ready #1287

Merged

Conversation

abbshr
Copy link
Contributor

@abbshr abbshr commented Mar 15, 2024

Is this a bug fix or adding new feature?

bug fix

What is this PR about? / Why do we need it?

removeNotReadyTaint() just call one time, so there may be accident the taint didn't remove successfully,
lead to node unschedulable for the pod can't tolerate the taint, this PR make sure the startup taint will eventually being removed after efs driver ready.

What testing is done?
test the compensation mechanism

Copy link

linux-foundation-easycla bot commented Mar 15, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 15, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @abbshr!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @abbshr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 15, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 15, 2024
@seanzatzdev-amazon
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 19, 2024
@seanzatzdev-amazon
Copy link
Contributor

Thank you for raising this PR @abbshr , as mentioned by the bot above, please follow the CLA authorization process here: #1287 (comment)

Believe this PR should address the following issue: #1320

@CMaylone
Copy link

Hello, anything I can help do in order to get this merged? We have experienced the taint not being cleared in our clusters and have a temp hack in place to mitigate the issue. We would love to use this fix instead!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 18, 2024
@abbshr
Copy link
Contributor Author

abbshr commented May 18, 2024

Signed CLA~

/cc @seanzatzdev-amazon

@seanzatzdev-amazon
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abbshr, seanzatzdev-amazon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6d8c526 into kubernetes-sigs:master Jun 7, 2024
6 checks passed
@MrMarkW
Copy link

MrMarkW commented Jun 18, 2024

When will this get released?

@mskanth972
Copy link
Contributor

mskanth972 commented Jun 25, 2024

Hi @abbshr, we are trying to release this PR. We have cherry picked this commit but bot prompts that these commits were not CLA authorized. Can you resolve that. For example below,
#1389

@abbshr
Copy link
Contributor Author

abbshr commented Jun 28, 2024

Hi @abbshr, we are trying to release this PR. We have cherry picked this commit but bot prompts that these commits were not CLA authorized. Can you resolve that. For example below, #1389

@mskanth972 Done

@mamoit
Copy link

mamoit commented Nov 8, 2024

Even with the latest efs-csi-driver version we're still getting lingering taints even though the driver logs state that the taints were removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants