-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Fargate support in the EFS CSI Controller #1195
Conversation
Welcome @rimaulana! |
Hi @rimaulana. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
@seanzatzdev-amazon: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mskanth972, rimaulana, seanzatzdev-amazon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
bug fix
What is this PR about? / Why do we need it?
Current controller can use Kubernetes metadata to get node's instance ID from node's ProviderID. However, on Fargate, the ProviderID of Fargate node has different pattern than an EC2 instance ID. I am adding a fix that will pull the task ID from Fargate node ProviderID and allow CSI Controller to run as Fargate pod. This PR will fix #1100
What testing is done?