-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSI_NODE_NAME to node Daemonset #1124
Add CSI_NODE_NAME to node Daemonset #1124
Conversation
We added CSI_NODE_NAME as an environment variable to the Helm Chart's node Daemonset, but we forget to add it to our kustomize deploy files as well. This is required for users who have IMDS disabled on their cluster, and who install the driver using kustomize.
Hi @RyanStan. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mskanth972, RyanStan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mskanth972: Failed to re-open PR: state cannot be changed. The pull request cannot be reopened. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We added CSI_NODE_NAME as an environment variable to the Helm Chart's node Daemonset, but we forget to add it to our kustomize deploy files as well. This is required for users who have IMDS disabled on their cluster, and who install the driver using kustomize.
This fixes #1111.
For more background,
This recent commit removed
hostNetwork = true
from the node daemonset. This means that the Node Daemonset Pods cannot use IMDS for getting the region.A while ago, this commit was merged which allows us to pull EC2 info from Kubernetes instead of IMDS if IMDS is enabled. However, it requires the
CSI_NODE_NAME
env variable to be set. The author of this commit only added it to the Controller Deployment, but our Node Daemonset needs it as well. Thus, that's why the commit above, wherehostNetwork = true
was removed, also introduced thisCSI_NODE_NAME
to our Helm Chart. However, it wasn't added to the Node daemonset spec that our Kustomize files use.Is this a bug fix or adding new feature?
Bug fix
What testing is done?
I applied a static provisioning example while enforcing IMDSv2 was used (which disabled IMDS).