Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm chart doesn't render podAnnotations for controller-deployment #450

Closed
MaksymDolgykh opened this issue May 19, 2021 · 1 comment
Closed

Helm chart doesn't render podAnnotations for controller-deployment #450

MaksymDolgykh opened this issue May 19, 2021 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@MaksymDolgykh
Copy link

/kind bug

What happened?
Helm chart doesn't render .Values.podAnnotations for controller-deployment. Instead it render's .Values.node.podAnnotations

What you expected to happen?
I assume .Values.podAnnotations should be used for the controller Deployment and .Values.node.podAnnotations for node DaemonSet

How to reproduce it (as minimally and precisely as possible)?

Anything else we need to know?:
helm chart version 1.2.4

Environment

  • Kubernetes version (use kubectl version):
  • Driver version:
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 19, 2021
MaksymDolgykh added a commit to MaksymDolgykh/aws-efs-csi-driver that referenced this issue May 19, 2021
@MaksymDolgykh
fix(helm): use podAnnotations for the controller deployment in helm c…
6c6a078 
…hart kubernetes-sigs#450
@MaksymDolgykh MaksymDolgykh mentioned this issue May 19, 2021
Closed
@MaksymDolgykh
Copy link
Author

This was fixed as part of #406.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use podAnnotations for the controller deployment in helm chart MaksymDolgykh/aws-efs-csi-driver
2 participants
@MaksymDolgykh @k8s-ci-robot