utilize latest go sdk to ensure createVolume idempotency

[AndyXiangLi]

Is this a bug fix or adding new feature?
Fixes #165

What is this PR about? / Why do we need it?
EBS team has updated the createVolume api to accept ClientToken in the createVolume request. doc here
With ClientToken, EBS will be able to ensure the createVolume Idempotency at Api level.
I think it is ok to keep inflight cache as it is, it ensure the driver level idempotency, and this change is more on the api level.
What testing is done?
unit test
sanity test
Manually tested described in the original re-produce step and observed only one volume is created

csc controller create-volume -e <endpoint> --cap 1,1 xiang-test --req-bytes 1024000 & \
> csc controller create-volume -e <endpoint> --cap 1,1 xiang-test --req-bytes 1024000
[1] 2801280
Create volume request for xiang-test is already in progress

Please use -h,--help for more information
"vol-0c8323ca0f9ab1a6d"	1073741824

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndyXiangLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [AndyXiangLi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[AndyXiangLi]

With the volumeName in the ClientToken, we no longer need describeVolume to check if the volume has already been created or not. But we will also lose some visibility to customer, if the two createVolume requests have same clientToken(volumeName) but different parameters (size or snapshotId), ebs api will return general idempotency violation exception. (instead of saying diff size or diff snapshotId)

Open to any idea, if you want me to add it back

[vdhanan]

i'm good with removing this code

[vdhanan]

i'm confused by this test case. don't you need a snapshot ID in the diskOptions to get a Snapshot not found error?

[AndyXiangLi]

It's testing cloud.go so we don't need to actually provide a valid snapshotId, this test case just expect go sdk to return snapshot not found fault code to the client and see if client can handle the error properly.

[vdhanan]

i see. we're just checking that the error gets handled. makes sense.

[vdhanan]

/lgtm

[vdhanan]

let's remove the vendor directory soon haha. these PRs are unnecessarily big

[AndyXiangLi]

let's remove the vendor directory soon haha. these PRs are unnecessarily big

Yeah, agree