-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/allow add debug args #970
Feature/allow add debug args #970
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @mkkatica! |
Hi @mkkatica. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -59,6 +59,8 @@ tolerations: [] | |||
topologySpreadConstraints: [] | |||
|
|||
controller: | |||
# If arbitrary args like "--aws-sdk-debug-log=true" need to be passed, use this value | |||
# additionalArgs: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't comment this line out
@mkkatica you will need to sign the CLA before this can be tested/merged |
I went through our internal process to get added to our Company CLA. That is complete and the status should be reflected in the license check. |
Yep, looks good. Now you just need a kubernetes-sigs member to flag it as okay to test. |
/ok-to-test thanks |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krmichel, mkkatica, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
Adding a new feature.
What is this PR about? / Why do we need it?
I was trying to debug a deployment of the EBS CSI and needed the
--aws-sdk-debug-log
flag set to true. I could not do it from the chart, so I had to keep editing the deployment in-place, and my CI process kept redeploying the helm chart. Being able to set this value from the chart, and other aribitrary commandline flags would make it easier for power users to debug.What testing is done?
I've templated the chart a few times with different values, and deployed it to a cluster without issue.