release-1.1: Release 1.1.1 and chart v1.2.4 with inFlight cache race fix #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
wongma7
changed the title
wongma7
force-pushed
the
1.1.1
branch
2 times, most recently
from
ed4066a to
747e6de
Compare
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/retest |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature? bug fix
What is this PR about? / Why do we need it? release the fix merged here #924 (comment)
I didn't see other fixes release-1.1...master worth cherry-picking in to 1.1.x branch. They are mostly eks e2e testing changes and helm chart-specific fixes which can be released separately via helm chart releases. (Which I am adding a CHANGELOG for btw.) Plus the windows refactor and the instance metadata refactor which I don't see the point in cherry-picking.
windows support in particular will probably come in 1.2.0 to signal it, or if nothing else because it's been a few months and we're due for another minor version bump.
What testing is done?