Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add golint verification #95

Merged
merged 2 commits into from
Nov 7, 2018
Merged

Add golint verification #95

merged 2 commits into from
Nov 7, 2018

Conversation

leakingtapan
Copy link
Contributor

@leakingtapan leakingtapan commented Nov 5, 2018 •
edited
Loading

Fixes: #83

Ran integration test manual and verified that the test is passed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 5, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 5, 2018
@coveralls
Copy link

coveralls commented Nov 5, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 117

  • 6 of 12 (50.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 51.259%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloud/fakes.go 0 1 0.0%
pkg/driver/controller.go 1 2 50.0%
pkg/cloud/cloud.go 1 5 20.0%
Totals Coverage Status
Change from base Build 116: 0.1%
Covered Lines: 570
Relevant Lines: 1112
💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 5, 2018
@leakingtapan leakingtapan force-pushed the golint branch 2 times, most recently from 29c4804 to 0964dbf Compare November 5, 2018 21:04
bertinatto
bertinatto reviewed Nov 6, 2018
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not adding the label in case you want to address the nit.

Feel free to merge manually.

tests/integration/setup_test.go Outdated Show resolved Hide resolved
@bertinatto
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2018
@k8s-ci-robot k8s-ci-robot merged commit 6edfe2a into kubernetes-sigs:master Nov 7, 2018
@leakingtapan leakingtapan deleted the golint branch November 7, 2018 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@d-nishi d-nishi Awaiting requested review from d-nishi

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@bertinatto bertinatto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leakingtapan @k8s-ci-robot @coveralls @bertinatto