Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip volume expansion if block node #916

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

gnufied
Copy link
Contributor

@gnufied gnufied commented Jun 2, 2021

No expansion on the node should be necessary if device is of type raw block

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 2, 2021
@k8s-ci-robot k8s-ci-robot requested review from ddebroy and vdhanan June 2, 2021 20:07
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 2, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2023

  • 5 of 7 (71.43%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 79.096%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/driver/controller.go 5 7 71.43%
Totals Coverage Status
Change from base Build 2021: -0.03%
Covered Lines: 1994
Relevant Lines: 2521

💛 - Coveralls

@wongma7
Copy link
Contributor

wongma7 commented Jun 2, 2021

/lgtm
/approve

looks like nodeexpandvolume will no-op anyway, but this is obv. better. thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wongma7 wongma7 merged commit 3df341a into kubernetes-sigs:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants