-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove WellKnownTopologyKey from PV Topology #912
remove WellKnownTopologyKey from PV Topology #912
Conversation
Welcome @Elbehery! |
Hi @Elbehery. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pull Request Test Coverage Report for Build 2018
💛 - Coveralls |
/ok-to-test |
27add9f
to
1dd799b
Compare
/lgtm |
@Elbehery: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Elbehery, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@wongma7, how do you deal with decreased unit test coverage? -0.008%, that's like one line? |
@jsafrane yeah coveralls is too finicky, I tried increasing threshold and will remove it if that doesn't work, I'm always manually merging to get around it anyway. |
Is this a bug fix or adding new feature?
bug fix
What is this PR about? / Why do we need it?
fixes kubernetes/kubernetes#102248
What testing is done?
modified testing and verified