add custom useragent suffix #910
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdhanan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Pull Request Test Coverage Report for Build 2022
💛 - Coveralls |
k8s-ci-robot
added
size/S
vdhanan
force-pushed
the
useragent
branch
3 times, most recently
from
940d4ec to
a17ddc8
Compare
| @@ -39,6 +39,8 @@ spec: | |||
| - --logtostderr | |||
| - --v=2 | |||
| env: | |||
| - name: CSI_DRIVER_NAME | |||
There was a problem hiding this comment.
Why we want to expose the name as env variable? Feel like it would be more accurate if the useragent is fixed..
There was a problem hiding this comment.
yeah I agree, better to just keep it fixed/hardcoded
There was a problem hiding this comment.
my thinking was that if the driver's name changed for whatever reason, we'd only have to change it in one place. i don't have a strong preference here, so i'll just hardcode it.
charts/aws-ebs-csi-driver/Chart.yaml
Outdated
| @@ -2,7 +2,7 @@ apiVersion: v1 | |||
| appVersion: "1.0.0" | |||
| name: aws-ebs-csi-driver | |||
| description: A Helm chart for AWS EBS CSI Driver | |||
| version: 1.2.0 | |||
| version: 1.3.0 | |||
There was a problem hiding this comment.
correct me if I'm wrong.. it should be 1.0.3 instead of 1.3.0 as the driver version is still on 1.0.x
There was a problem hiding this comment.
I think, if we avoid exposing env variable, then we dont need to change the chart at all
There was a problem hiding this comment.
the helm chart version is 1.2.0 on master right now. is that a problem?
There was a problem hiding this comment.
In general, the helm chart version doesn't have to and likely won't match the version of the application. That is what appVersion is for to specify the version of the application to use if the user doesn't override it. If the chart keeps getting new features added that work with 1.0.0. of the driver, it will continue to increase in version independent of the driver version.
k8s-ci-robot
added
size/XS
|
/lgtm thanks |
k8s-ci-robot
added
the
lgtm
Is this a bug fix or adding new feature?
new feature
What is this PR about? / Why do we need it?
modifies the aws sdk client's useragent string to differentiate the ebs csi driver's requests
What testing is done?
turned on debug logs and confirmed that user agent had new string appended