Update driver version to 0.1.0-alpha #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leakingtapan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Pull Request Test Coverage Report for Build 98
💛 - Coveralls |
Pull Request Test Coverage Report for Build 101
💛 - Coveralls |
bertinatto
reviewed
Nov 2, 2018
Makefile
Outdated
|
|
||
| .PHONY: aws-ebs-csi-driver | ||
| aws-ebs-csi-driver: | ||
| mkdir -p bin | ||
| go build -o bin/aws-ebs-csi-driver ./cmd/aws-ebs-csi-driver | ||
| go build -ldflags "-X github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver.VendorVersion=${VERSION}" -o bin/aws-ebs-csi-driver ./cmd/ |
There was a problem hiding this comment.
This won't the binary binary that goes into the image. The Dockerfile is not calling make, it's calling go build directly.
We should change the Dockerfile to use make instead. We need to install it first, if we want to keep using golang:1.11.1-alpine3.8.
There was a problem hiding this comment.
Good catch. updated to use golang1.11.1-stretch as build image
Switch to use golang1.11.1-stretch as build image so that we can delegate to make file for binary compilation without duplicating the logic in both makefile and dockerfile.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
jsafrane
pushed a commit
to jsafrane/aws-ebs-csi-driver
that referenced
this pull request
Apr 6, 2020
carry: Fix binary location source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #82