Fix kustomize RBAC bindings to have namespace kube-system #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Pull Request Test Coverage Report for Build 1947
💛 - Coveralls |
|
This PR broke our aws-ebs-csi-driver deployment which is configured to run in its own namespace. All of the ClusterRoleBinding's and RoleBinding's were shifted to the kube-system namespace causing the driver pods to fail with retrieving resource lock errors when upgrading to 1.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature? /bug
What is this PR about? / Why do we need it? I broke the RBAC. helm used to hardcode kube-system so kustomize templates inherited kube-system. Then we stopped hardcoding it in favour of RElease.namespace so kustomize templates started inheriting default. Unfortunately this breaks things for users who already had kustomize installed in kube-system so let's revert by adding -n kube-system to the helm template command.
What testing is done?