Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pod disruption budget for csi controller #857

Merged
merged 1 commit into from
Apr 28, 2021
Merged

add pod disruption budget for csi controller #857

merged 1 commit into from
Apr 28, 2021

Conversation

vdhanan
Copy link
Contributor

@vdhanan vdhanan commented Apr 28, 2021

Is this a bug fix or adding new feature?
fixes #512

What is this PR about? / Why do we need it?

What testing is done?
manually tested with kustomize and helm

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 28, 2021
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 28, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @vdhanan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 28, 2021
@AndyXiangLi
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 28, 2021
AndyXiangLi
AndyXiangLi reviewed Apr 28, 2021
View reviewed changes
deploy/kubernetes/base/controller.yaml
@@ -91,7 +91,7 @@ spec:
- name: socket-dir
mountPath: /var/lib/csi/sockets/pluginproxy/
- name: csi-attacher
image: k8s.gcr.io/sig-storage/csi-attacher:v3.0.0
image: k8s.gcr.io/sig-storage/csi-attacher:v3.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need to update the image version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't update it manually, so i'm assuming one of the make recipes bumped the version. @wongma7 do you know why it was updated?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah probably make generate-kustomize. I double checked and this change makes the helm chart values.yaml match the kustomize, so it's a sound change

@wongma7
Copy link
Contributor

wongma7 commented Apr 28, 2021

/approve

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1910

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.253%
Totals Coverage Status
Change from base Build 1897: 0.0%
Covered Lines: 1952
Relevant Lines: 2463
💛 - Coveralls

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdhanan, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2021
@wongma7
Copy link
Contributor

wongma7 commented Apr 28, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2ab89fd into kubernetes-sigs:master Apr 28, 2021
@ayberk ayberk mentioned this pull request Apr 28, 2021
Closed
@vdhanan vdhanan mentioned this pull request Apr 29, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyXiangLi AndyXiangLi AndyXiangLi left review comments

@wongma7 wongma7 wongma7 left review comments

@bertinatto bertinatto Awaiting requested review from bertinatto

@ddebroy ddebroy Awaiting requested review from ddebroy

Assignees

@wongma7 wongma7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PodDisruptionBudget needed for autoscaling
5 participants
@vdhanan @k8s-ci-robot @AndyXiangLi @wongma7 @coveralls