Add additional logging for outpost arn handling #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ayberk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Pull Request Test Coverage Report for Build 1888
💛 - Coveralls |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
AndyXiangLi
reviewed
Apr 23, 2021
| return nil, fmt.Errorf("something went wrong while getting EC2 outpost arn") | ||
| return nil, fmt.Errorf("something went wrong while getting EC2 outpost arn: %s", err.Error()) | ||
| } else if err == nil { | ||
| klog.Infof("Running in an outpost environment with arn: %s", outpostArn) |
There was a problem hiding this comment.
nit: can you set the log level to 5 for these two log statements.
Want to make every log explicitly set with a level, so later we can filter the log by their level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently encountered a case where driver wouldn't use the outpost arn despite metadata being available. I'm adding more logging around it to help troubleshooting the issue in the future.