Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release v0.10.0 #820

Merged
merged 1 commit into from
Apr 1, 2021
Merged

release v0.10.0 #820

merged 1 commit into from
Apr 1, 2021

Conversation

vdhanan
Copy link
Contributor

@vdhanan vdhanan commented Mar 31, 2021

Is this a bug fix or adding new feature?
release commit

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 31, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @vdhanan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 31, 2021
@AndyXiangLi
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 31, 2021
ayberk
ayberk reviewed Mar 31, 2021
View reviewed changes
charts/aws-ebs-csi-driver/values.yaml
@@ -70,7 +70,7 @@ resources:

priorityClassName: ""
nodeSelector: {}
tolerateAllTaints: true
tolerateAllTaints: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have these changes? Release commit should only have the version update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, in retrospect, this should have been a separate commit. will split it out into two commits next time.

@vdhanan
Copy link
Contributor Author

vdhanan commented Mar 31, 2021

/test pull-aws-ebs-csi-driver-migration-test-latest

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1787

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.789%
Totals Coverage Status
Change from base Build 1777: 0.0%
Covered Lines: 1756
Relevant Lines: 2147
💛 - Coveralls

@AndyXiangLi
Copy link
Contributor

I will merge this PR first. Like Varun mentioned, next time we should only include release related change.
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndyXiangLi, vdhanan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit a5882e3 into kubernetes-sigs:master Apr 1, 2021
@vdhanan vdhanan mentioned this pull request Apr 29, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayberk ayberk ayberk left review comments

@bertinatto bertinatto Awaiting requested review from bertinatto

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees

@AndyXiangLi AndyXiangLi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vdhanan @k8s-ci-robot @AndyXiangLi @coveralls @ayberk @ArchiFleKs