Add support for creating encrypted volume #80
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leakingtapan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
Pull Request Test Coverage Report for Build 85
💛 - Coveralls |
| } | ||
| if len(diskOptions.KmsKeyID) > 0 { | ||
| request.KmsKeyId = aws.String(diskOptions.KmsKeyID) | ||
| request.Encrypted = aws.Bool(true) |
There was a problem hiding this comment.
What happen if diskOptions.Encrypted is true and diskOptions.KmsKeyID is empty? Is this something we want to handle?
There was a problem hiding this comment.
In case of KmsKeyID is empty, EBS will use a default key to create the volume if Encrypted is set true. See: https://docs.aws.amazon.com/sdk-for-go/api/service/ec2/#CreateVolumeInput
| Encrypted bool | ||
| // fully qualified resource name to the key to use for encryption. | ||
| // example: arn:aws:kms:us-east-1:012345678910:key/abcd1234-a123-456a-a12b-a123b4cd56ef | ||
| KmsKeyID string |
There was a problem hiding this comment.
Would it make sense to have only this field (and get rid of Encrypted)?
There was a problem hiding this comment.
See above comment
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Fixes: #16