[chart] Allow resources override for node DaemonSet + priorityClassName #732

dntosas · 2021-02-09T08:50:17Z

CSI controller and node have different needs in a manner of capacity so
in this commit we enable users to define specific resources for the node
component. This will allow users not to reserve not needed resources on
all of their instances as node is a DaemonSet and may not need as much
CPU/Memory as the controller Pods.

Is this a bug fix or adding new feature?
Adding a feature of overriding resource for the node

What is this PR about? / Why do we need it?
Mitigate overprovisioning capacity for node component

What testing is done?
Tested on our internal clusters

k8s-ci-robot · 2021-02-09T08:50:25Z

Welcome @dntosas!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-02-09T08:50:26Z

Hi @dntosas. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

coveralls · 2021-02-09T09:02:37Z

Pull Request Test Coverage Report for Build 1580

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.286%

Totals
Change from base Build 1572:	0.0%
Covered Lines:	1707
Relevant Lines:	2100

💛 - Coveralls

ayberk

/ok-to-test

ayberk · 2021-02-09T18:03:15Z

charts/aws-ebs-csi-driver/templates/node.yaml

@@ -80,7 +81,7 @@ spec:
            timeoutSeconds: 3
            periodSeconds: 10
            failureThreshold: 5
-          {{- with .Values.resources }}
+          {{- with .Values.node.resources }}


I am not a big fan of this change. This would be a breaking change and force the operators to update their setup. Can we somehow give this new value priority and if it doesn't exist fallback to .Values.resources? We can add a deprecation note for the old field on the values file.

Good catch ^^

Pushed some changes, adding a condition so the additions would be backwards compatible. Tell me if something like that would work for you :)

ayberk · 2021-02-09T18:05:27Z

charts/aws-ebs-csi-driver/templates/node.yaml

@@ -103,7 +104,7 @@ spec:
              mountPath: /csi
            - name: registration-dir
              mountPath: /registration
-          {{- with .Values.resources }}
+          {{- with .Values.node.resources }}


Similarly here. I understand this makes more sense, but we still have to make sure we don't break existing setups without any warning.

CSI controller and node have different needs in a manner of capacity so in this commit we enable users to define specific resources for the node component. This will allow users not to reserve not needed resources on all of their instances as node is a DaemonSet and may not need as much CPU/Memory as the controller Pods. Signed-off-by: dntosas <[email protected]>

CSI components and especially the node one, may be critical for operators so in this commit we enable them to define priorities for this kind of Pods. Signed-off-by: dntosas <[email protected]>

ayberk · 2021-02-11T17:51:39Z

Looks great, thanks! It'd be great if you can follow-up with a small CR to add a comment for the resources fields so we have a deprecation warning.

/lgtm
/approve

k8s-ci-robot · 2021-02-11T17:51:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ayberk, dntosas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ayberk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 9, 2021

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 9, 2021

k8s-ci-robot requested review from bertinatto and gnufied February 9, 2021 08:50

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 9, 2021

dntosas force-pushed the allow-resources-override-for-node branch from c5c512b to e81e584 Compare February 9, 2021 10:06

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2021

dntosas changed the title ~~[chart] Allow resources override for node DaemonSet~~ [chart] Allow resources override for node DaemonSet Feb 9, 2021

dntosas changed the title ~~[chart] Allow resources override for node DaemonSet~~ [chart] Allow resources override for node DaemonSet + priorityClassName Feb 9, 2021

ayberk suggested changes Feb 9, 2021

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 9, 2021

dntosas added 2 commits February 10, 2021 08:23

[chart] Ability to add priorityClassName

5a03305

CSI components and especially the node one, may be critical for operators so in this commit we enable them to define priorities for this kind of Pods. Signed-off-by: dntosas <[email protected]>

dntosas force-pushed the allow-resources-override-for-node branch from c9b1c39 to 5a03305 Compare February 10, 2021 06:23

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 10, 2021

k8s-ci-robot assigned ayberk Feb 11, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2021

k8s-ci-robot merged commit d22d0db into kubernetes-sigs:master Feb 11, 2021

dntosas deleted the allow-resources-override-for-node branch February 14, 2021 08:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[chart] Allow resources override for node DaemonSet + priorityClassName #732

[chart] Allow resources override for node DaemonSet + priorityClassName #732

dntosas commented Feb 9, 2021

k8s-ci-robot commented Feb 9, 2021

k8s-ci-robot commented Feb 9, 2021

coveralls commented Feb 9, 2021 •

edited

Loading

ayberk left a comment

ayberk Feb 9, 2021

dntosas Feb 10, 2021

ayberk Feb 9, 2021

ayberk commented Feb 11, 2021

k8s-ci-robot commented Feb 11, 2021

[chart] Allow resources override for node DaemonSet + priorityClassName #732

[chart] Allow resources override for node DaemonSet + priorityClassName #732

Conversation

dntosas commented Feb 9, 2021

k8s-ci-robot commented Feb 9, 2021

k8s-ci-robot commented Feb 9, 2021

coveralls commented Feb 9, 2021 • edited Loading

Pull Request Test Coverage Report for Build 1580

💛 - Coveralls

ayberk left a comment

Choose a reason for hiding this comment

ayberk Feb 9, 2021

Choose a reason for hiding this comment

dntosas Feb 10, 2021

Choose a reason for hiding this comment

ayberk Feb 9, 2021

Choose a reason for hiding this comment

ayberk commented Feb 11, 2021

k8s-ci-robot commented Feb 11, 2021

coveralls commented Feb 9, 2021 •

edited

Loading