Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for storage class parameter - volume type #73

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Implement support for storage class parameter - volume type #73

merged 1 commit into from
Oct 22, 2018

Conversation

leakingtapan
Copy link
Contributor

Fixes: #63

I regroup the consts to make them more readable and changed IOPSPerGB type from int64 to int since int should be sufficient.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 18, 2018
@k8s-ci-robot k8s-ci-robot requested a review from jsafrane October 18, 2018 22:50
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 18, 2018
@coveralls
Copy link

coveralls commented Oct 18, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 71

  • 10 of 13 (76.92%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 49.347%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloud/cloud.go 0 1 0.0%
pkg/driver/controller.go 10 12 83.33%
Totals Coverage Status
Change from base Build 69: 0.3%
Covered Lines: 529
Relevant Lines: 1072
💛 - Coveralls

bertinatto
bertinatto reviewed Oct 19, 2018
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two smal nits, but feel free to merge as is if you don't feel like you should address them.

pkg/cloud/cloud.go Outdated
const (
// DefaultVolumeSize represents the default volume size.
// TODO: what should be the default size?
DefaultVolumeSize int64 = 1 * 1024 * 1024 * 1024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we take the chance and solve this TODO?

What would be the good volume limit? Does AWS have any recommendation about this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWS console uses 100 GiB as the default size for gp2/io1 and 500 GiB for sc1/st1. We can use the same value. How do you think we use this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR to use 100 GiB.

pkg/driver/controller.go Outdated Show resolved Hide resolved
@bertinatto
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2018
@k8s-ci-robot k8s-ci-robot merged commit 6aa96a3 into kubernetes-sigs:master Oct 22, 2018
@leakingtapan leakingtapan deleted the volume-type branch October 22, 2018 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@bertinatto bertinatto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leakingtapan @k8s-ci-robot @coveralls @bertinatto