-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More controll over snapshot-controller scheduling #708
More controll over snapshot-controller scheduling #708
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @alex-berger! |
Hi @alex-berger. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pull Request Test Coverage Report for Build 1555
💛 - Coveralls |
/assign @ayberk |
This makes sense to me, thanks for you contribution. Can you please update the chart version? |
/ok-to-test |
Apply nodeSelector, affinity, tolerations and priorityClassName to snapshoter.
Signed-off-by: Alexander Berger <[email protected]>
5691869
to
528322e
Compare
/approve Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alex-berger, ayberk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Apply nodeSelector, affinity, tolerations and priorityClassName to snapshoter. This PR brings the
snapshot-controller
StatefulSet on par with theebs-csi-controller
Deployment, applying the same scheduling settings to it. This is importantfor clusters where cluster-addons (like the aws-ebs-csi-driver) are scheduled to dedicated node groups, which are
isolated from other (general purpose) node groups.